[FIX] account_payment_pro: include to_pay_move_line_ids in _compute_to_pay_amount dependency#968
Open
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Open
[FIX] account_payment_pro: include to_pay_move_line_ids in _compute_to_pay_amount dependency#968rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR corrige el recálculo del importe “To Pay” en account_payment_pro, asegurando que se invalide/recalcule cuando cambian las líneas seleccionadas a pagar.
Changes:
- Se añade
to_pay_move_line_idscomo dependencia de_compute_to_pay_amount. - Se fuerza el reseteo de
to_pay_amountal ejecutarremove_all().
|
|
||
| def remove_all(self): | ||
| self.to_pay_move_line_ids = False | ||
| self.to_pay_amount = 0.0 |
There was a problem hiding this comment.
En remove_all() se escribe directamente to_pay_amount, que es un campo compute con inverse. Esto puede dejar unreconciled_amount sin resetear si currency_id todavía no está seteada (el inverse hace un guard con if rec.currency_id), o introducir ajustes negativos no deseados. Sería más seguro/resetear explícitamente unreconciled_amount (y dejar que _compute_to_pay_amount derive to_pay_amount) en lugar de escribir el campo compute.
Suggested change
| self.to_pay_amount = 0.0 | |
| self.unreconciled_amount = 0.0 |
rov-adhoc
force-pushed
the
18.0-h-113286-rov
branch
4 times, most recently
from
b904627 to
65b4b3f
Compare
…o_pay_amount dependency
rov-adhoc
force-pushed
the
18.0-h-113286-rov
branch
from
65b4b3f to
6b909e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.